Modified annotation
#814
Merged
Modified annotation
#814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #814 +/- ##
=========================================
Coverage 74.52% 74.52%
Complexity 1135 1135
=========================================
Files 181 181
Lines 4201 4201
Branches 335 335
=========================================
Hits 3131 3131
Misses 941 941
Partials 129 129 |
armiol
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
Modifiedannotation type which is needed for the cases when Spine tools update the code generated by other tools.We need to tell who did the modifications because the changes ProtoData and Model Compilers apply are significant.
We also may want to modify the Protobuf generated code even further. So, relevant attributions are appropriate and wanted.