Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have separate types for every_is and is options #825

Merged
merged 5 commits into from
Sep 13, 2024

Conversation

alexander-yevsyukov
Copy link
Contributor

This PR introduces a separate EveryIsOption type for the (every_is) file option. Previously the file option and the message option (is) were served by the same type called IsOption.

During the reimplementation of the code generation process in McJava it was decided that the generate flag of IsOption does not make sense for (is) option because it would produce a marker interface for only one message class.

So, this PR renames the existing IsOption into EveryIsOption and introduces new IsOption type which does not have the generate flag.

Other notable changes

  • The constraint_for message option was deprecated because new Validation library does not support this mechanism which turned to be really hard to use.

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.96%. Comparing base (de60491) to head (e0a58cf).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #825   +/-   ##
=========================================
  Coverage     74.96%   74.96%           
  Complexity     1170     1170           
=========================================
  Files           189      189           
  Lines          4246     4246           
  Branches        338      338           
=========================================
  Hits           3183     3183           
  Misses          932      932           
  Partials        131      131           

@alexander-yevsyukov alexander-yevsyukov changed the title Have separate types for every_is from is options Have separate types for every_is and is options Sep 12, 2024
@alexander-yevsyukov alexander-yevsyukov merged commit f9e4d5b into master Sep 13, 2024
7 checks passed
@alexander-yevsyukov alexander-yevsyukov deleted the separate-every-is-option branch September 13, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants