Have separate types for every_is
and is
options
#825
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a separate
EveryIsOption
type for the(every_is)
file option. Previously the file option and the message option(is)
were served by the same type calledIsOption
.During the reimplementation of the code generation process in McJava it was decided that the
generate
flag ofIsOption
does not make sense for(is)
option because it would produce a marker interface for only one message class.So, this PR renames the existing
IsOption
intoEveryIsOption
and introduces newIsOption
type which does not have thegenerate
flag.Other notable changes
constraint_for
message option was deprecated because new Validation library does not support this mechanism which turned to be really hard to use.