Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues found by golangci-linter #45

Merged
merged 25 commits into from
Sep 5, 2024

Conversation

olena-zmiiova
Copy link

This PR contains fixes for the code styles, security issues, format of imports and comments, and code complexity.

The issues were found in this run: https://github.com/SpineEventEngine/embed-code/actions/runs/10705034029/job/29679432200?pr=44

Copy link
Collaborator

@dmytro-kashcheiev dmytro-kashcheiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olena-zmiiova see comments.

embed-code-go/cli/cli.go Outdated Show resolved Hide resolved
embed-code-go/embed_code.go Outdated Show resolved Hide resolved
embed-code-go/fragmentation/fragmentation.go Outdated Show resolved Hide resolved
@olena-zmiiova olena-zmiiova changed the base branch from embed-code-go-add-linter to embed-code-go September 5, 2024 12:09
Copy link
Collaborator

@dmytro-kashcheiev dmytro-kashcheiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olena-zmiiova olena-zmiiova merged commit d280aad into embed-code-go Sep 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants