Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor cli package and entrypoint #49

Merged
merged 63 commits into from
Sep 12, 2024
Merged

Refactor cli package and entrypoint #49

merged 63 commits into from
Sep 12, 2024

Conversation

olena-zmiiova
Copy link

@olena-zmiiova olena-zmiiova commented Sep 9, 2024 •
edited
Loading

In the scope of this PR, the following points were refactored:

  • The entrypoint file is renamed to main.go.
  • CLI arguments were renamed (from snake case to kebab case, dir and root renamed to path).
  • Improved error handling.
  • Rearranged code for validation, and added validation for directory and file paths.
  • Added logs.
  • Added package files with common file operations used in other packages.

@olena-zmiiova olena-zmiiova self-assigned this Sep 9, 2024
dmytro-kashcheiev
dmytro-kashcheiev requested changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@dmytro-kashcheiev dmytro-kashcheiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olena-zmiiova see comments.

embed-code-go/cli/cli.go Outdated Show resolved Hide resolved
embed-code-go/cli/cli.go Outdated Show resolved Hide resolved
embed-code-go/cli/cli.go Outdated Show resolved Hide resolved
embed-code-go/cli/cli.go Outdated Show resolved Hide resolved
embed-code-go/cli/cli.go Outdated Show resolved Hide resolved
embed-code-go/cli/cli.go Show resolved Hide resolved
dmytro-kashcheiev
dmytro-kashcheiev approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@dmytro-kashcheiev dmytro-kashcheiev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olena-zmiiova LGTM with minor comments to address before the merge.

embed-code-go/cli/cli_validation.go Outdated Show resolved Hide resolved
embed-code-go/cli/cli_validation.go Outdated Show resolved Hide resolved
@olena-zmiiova olena-zmiiova merged commit c001938 into embed-code-go Sep 12, 2024
@olena-zmiiova olena-zmiiova mentioned this pull request Sep 12, 2024
Closed
@olena-zmiiova olena-zmiiova mentioned this pull request Sep 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-kashcheiev dmytro-kashcheiev dmytro-kashcheiev approved these changes

Assignees

@olena-zmiiova olena-zmiiova

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olena-zmiiova @dmytro-kashcheiev