Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor fragmentation package #51

Merged
merged 35 commits into from
Sep 18, 2024

Conversation

olena-zmiiova
Copy link

@olena-zmiiova olena-zmiiova commented Sep 13, 2024

The code was rearranged, and the remained issues from the linter were fixed, also added UTs using ginkgo and gomega libs.

@armiol
Copy link
Collaborator

armiol commented Sep 13, 2024

@olena-zmiiova JFYI, I have removed the quotation markdown symbol (>) and put an emoji to the PR description, because what you had was not a quote.

@olena-zmiiova olena-zmiiova removed the request for review from dmytro-kashcheiev September 16, 2024 05:44
@olena-zmiiova olena-zmiiova marked this pull request as ready for review September 16, 2024 13:10
Copy link
Collaborator

@dmytro-kashcheiev dmytro-kashcheiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olena-zmiiova see comments.

embed-code-go/analyzing/analyzing.go Outdated Show resolved Hide resolved
embed-code-go/files/files.go Outdated Show resolved Hide resolved
embed-code-go/files/files.go Outdated Show resolved Hide resolved
embed-code-go/fragmentation/partition.go Show resolved Hide resolved
embed-code-go/fragmentation/fragmentation.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@dmytro-kashcheiev dmytro-kashcheiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olena-zmiiova olena-zmiiova merged commit dabd7b3 into embed-code-go Sep 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants