Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin Gradle scripts #148

Merged
merged 5 commits into from
Jun 3, 2020
Merged

Kotlin Gradle scripts #148

merged 5 commits into from
Jun 3, 2020

Conversation

dmdashenkov
Copy link
Contributor

In this PR we translate Gradle scripts into Kotlin.

@dmdashenkov dmdashenkov self-assigned this Jun 2, 2020
@dmdashenkov dmdashenkov requested a review from armiol June 2, 2020 13:32
@dmdashenkov
Copy link
Contributor Author

@armiol, PTAL.

Copy link
Contributor

@armiol armiol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmdashenkov LGTM with a comment.

build.gradle.kts Outdated
from(Deps.scripts.repoLicenseReport(project))
from(Deps.scripts.generatePom(project))
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please kill these redundant lines.

@dmdashenkov dmdashenkov merged commit de1b7cf into master Jun 3, 2020
@dmdashenkov dmdashenkov deleted the kotlin-gradle-scripts branch June 3, 2020 08:15
@dmitrykuzmin dmitrykuzmin mentioned this pull request Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants