Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename a test module #68

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Rename a test module #68

merged 2 commits into from
Oct 2, 2023

Conversation

yevhenii-nadtochii
Copy link
Collaborator

This PR just renames one of the test modules.

:jvm-log4j-backend-our-context has been renamed to :jvm-log4j2-backend-our-context. It is for naming consistency. We have a backend implementation for Log4j2, not for the first or the upcoming third version (which is in alpha now).

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #68 (9000892) into master (725ad77) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #68   +/-   ##
=========================================
  Coverage     62.40%   62.40%           
  Complexity      821      821           
=========================================
  Files           119      119           
  Lines          3809     3809           
  Branches        512      512           
=========================================
  Hits           2377     2377           
  Misses         1228     1228           
  Partials        204      204           

@yevhenii-nadtochii yevhenii-nadtochii self-assigned this Oct 2, 2023
@yevhenii-nadtochii yevhenii-nadtochii marked this pull request as ready for review October 2, 2023 16:04
@yevhenii-nadtochii
Copy link
Collaborator Author

@armiol @alexander-yevsyukov PTAL

Copy link
Contributor

@alexander-yevsyukov alexander-yevsyukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yevhenii-nadtochii yevhenii-nadtochii merged commit 3a2ba61 into master Oct 2, 2023
7 checks passed
@yevhenii-nadtochii yevhenii-nadtochii deleted the rename-test-module branch October 2, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants