Fix filtering of source file sets #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armiol
approved these changes
Jul 21, 2024
There was a problem hiding this comment.
@alexander-yevsyukov same as with validation#129, I don't understand how this all touches gRPC output.
I've updated the PR description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the filtering of source file sets produced by gRPC when they are not applicable. Also it applies latest version of Validation which addresses the same issue.
Previously, actions relied on the call to SourceFileSet.hasJavaFiles, which checks for the presence of a Java file in the set. gRPC Protobuf compiler does produce Java files, but the output placed under the
grpcdirectory does not contain message files participating in gRPC calls. They are placed under thejavadirectory. Because of this it is not possible to find a source code file matching a message in the source file set under thegrpcdirectory.Now, we call
SourceFileSet.hasJavaOutput, which checks the target directory and that solves the filtering issue.