Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom source sets #4

Merged
merged 14 commits into from
Dec 3, 2021
Merged

Support custom source sets #4

merged 14 commits into from
Dec 3, 2021

Conversation

alexander-yevsyukov
Copy link
Contributor

@alexander-yevsyukov alexander-yevsyukov commented Dec 2, 2021

This PR:

  1. Adds the ability to handle a custom source set in JS code generation.
  2. Bumps dependency on tool-base and config.

Notable changes:

  • GenerateJsonParsers action class introduced. The class encapsulates the code generation logic which was previously implemented as static methods under McJsPlugin.
  • McJsExtension was renamed to McJsOptions.
  • All path-related properties of the plugin options were removed (similarly to those in McJavaOptions).

@alexander-yevsyukov alexander-yevsyukov self-assigned this Dec 2, 2021
@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #4 (64d687d) into master (ad26d3a) will increase coverage by 0.40%.
The diff coverage is 56.25%.

@@             Coverage Diff              @@
##             master       #4      +/-   ##
============================================
+ Coverage     93.38%   93.78%   +0.40%     
+ Complexity      253      249       -4     
============================================
  Files            43       44       +1     
  Lines           907      885      -22     
  Branches         32       33       +1     
============================================
- Hits            847      830      -17     
+ Misses           55       50       -5     
  Partials          5        5              

@alexander-yevsyukov alexander-yevsyukov marked this pull request as ready for review December 2, 2021 18:32
@alexander-yevsyukov
Copy link
Contributor Author

@armiol, during my absence, if needed, please feel free to pick this PR up. Otherwise, I hope to pick it up on Monday next week.

Copy link
Contributor

@dmdashenkov dmdashenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a small note.

build.gradle.kts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants