Teach Factory to create instances with arguments
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # dependencies.md
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9 +/- ##
============================================
+ Coverage 85.16% 85.67% +0.51%
- Complexity 99 102 +3
============================================
Files 13 13
Lines 364 391 +27
Branches 35 44 +9
============================================
+ Hits 310 335 +25
- Misses 43 44 +1
- Partials 11 12 +1 |
armiol
approved these changes
Jul 2, 2024
| * if the specified class does not have a parameterless | ||
| * constructors. Note that nested classes fall under this case | ||
| * if the specified class does not have a parameterless constructor. | ||
| * Note that nested classes fall under this case |
There was a problem hiding this comment.
Should we put a period at the end?
| /** | ||
| * Checks if this [KVisibility] is [public][KVisibility.PUBLIC]. | ||
| */ | ||
| private val KVisibility?.isPublic: Boolean | ||
| get() = this == KVisibility.PUBLIC | ||
|
|
||
| /** | ||
| * Tells if this class originates in the Kotlin code, returning `false` for classes |
| public WithParametersJava(String str, @Nullable Object any, Iterable<String> list) { | ||
| // Do nothing. | ||
| } | ||
|
|
Also: * Remove empty line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the
Factoryclass with the ability to create class instances passing given arguments to constructors.