Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use https + fix some broken links + reduce redirects #637

Merged
merged 15 commits into from
Dec 3, 2017
Merged

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Nov 26, 2017

Use HTTPS Links where possible.

Fixes #437 (comment) (partially)

@@ -78,7 +78,7 @@ Sponge Forums
regularly. https://forums.spongepowered.org/
Sponge Foundation
The financial side of the project, a separate entity that accepts, manages and distributes donations.
http://spongefoundation.org/
https://spongefoundation.org/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this link entirely, it just links to our main homepage.

@Spongy
Copy link

Spongy commented Nov 26, 2017

A preview for this pull request is available at https://cdn.rawgit.com/Spongy/SpongeDocs-PRs/87fe408/.

Here are some links to the pages that were modified:

Since the preview frequently changes, please link to this comment, not to the direct url to the preview.

@@ -92,7 +92,7 @@ Dedicated Servers
Installing Forge via Commandline
--------------------------------

1. Visit the `Minecraft Forge website <https://files.minecraftforge.net/>`_ and click "Show all downloads" to view the full
1. Visit the `Minecraft Forge website <http://files.minecraftforge.net/>`_ and click "Show all downloads" to view the full
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try using two underscores here (and below). It's a strange warning and I've no idea why it only happens with https, but that seems to fix it according to sphinx-doc/sphinx#3921

@ST-DDT
Copy link
Member Author

ST-DDT commented Nov 26, 2017

Fixed

Redirected links

Not Fixed yet

Unfixable yet

@ST-DDT
Copy link
Member Author

ST-DDT commented Nov 26, 2017

@ImMorpheus I hope i fixed all your findings correctly. How did you find them? Did you use a tool to check for them?

@Inscrutable Any idea how i should resolve the remaining entries? (Under Not Fixed yet) Or who might know how to properly update the references?

@ST-DDT ST-DDT changed the title Use https where possible Use https where possible + fix some broken links + reduce redirects Nov 26, 2017
@ST-DDT ST-DDT changed the title Use https where possible + fix some broken links + reduce redirects Use https + fix some broken links + reduce redirects Nov 26, 2017
@@ -16,4 +16,4 @@ list of banned IP addresses is available using the command ``/banlist ips``
A ban can be reversed using the command ``/pardon <name>`` or ``/pardon <ip-address>``


More information on Bans can be found at the `Minecraft Wiki <http://minecraft.gamepedia.com/Commands#ban>`_.
More information on Bans can be found at the `Minecraft Wiki <https://minecraft.gamepedia.com/Commands#ban>`_.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -15,7 +15,7 @@ Whenever you report a bug, please include the following:
* any other mods or plugins installed including their versions
* your :doc:`logs`

* please use a service like `GitHubs gist <https://gist.github.com/>`_ or `pastebin <http://pastebin.com/>`_ to provide
* please use a service like `GitHubs gist <https://gist.github.com/>`_ or `pastebin <https://pastebin.com/>`_ to provide
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SpongeForge issue template discourage the use of pastebin/hastebin. See: SpongePowered/SpongeForge@488af7c
This should probably be updated to reflect those changes.

@ImMorpheus
Copy link
Contributor

@ST-DDT Yup, good job.
And yes, https://github.com/wummel/linkchecker.

@Inscrutable
Copy link
Member

Awesome work! I can only really comment on the CoreMod definition - we could just add a description of what a Coremod was (I'll write it up if needed). I have no idea if Patreon has secret parameters, you might need to ask Dockter. You can safely edit them out for now anyway.

@ST-DDT
Copy link
Member Author

ST-DDT commented Nov 28, 2017

@Inscrutable If you could provide me with the CoreMod definition that would be nice. I could only guess its in detail definition.

@phit
Copy link
Contributor

phit commented Nov 28, 2017

@ST-DDT archive of the original page http://web.archive.org/web/20160906180457/http://www.minecraftforge.net/wiki/Core_Mod

@ST-DDT
Copy link
Member Author

ST-DDT commented Nov 28, 2017

We already have a small explanation there. Is it true to say that it was replaced by mixins?

@ST-DDT
Copy link
Member Author

ST-DDT commented Nov 28, 2017

As for the SpongeEventFactory and BoundedComparableValue, I will rephrase/change the sentences accordingly tommorow.

@ST-DDT
Copy link
Member Author

ST-DDT commented Nov 29, 2017

I guess everything is covered now. Ready for review.

@ryantheleach
Copy link
Contributor

No I do not think it's fair to say that they are replaced by Mixins.

Mixins are just one method of creating a CoreMod.

@Inscrutable
Copy link
Member

Hmmm. I think we should link to the archived page to explain CoreMods, as "sadly core modding is still a thing". Mixins can cover a lot of it, but so can any arbitrary hack (just with less compatibility).

@Inscrutable
Copy link
Member

Alternatively, brutalising the definition from the archive into something compact:
A CoreMod is a Forge mod that loads before Mojang classes are loaded, allowing it to modify native Minecraft code via Access Transformers, ASM class modification, or other Java bytecode manipulation.

@ST-DDT
Copy link
Member Author

ST-DDT commented Nov 30, 2017

Done

@@ -54,7 +54,7 @@ Ore
The Official Sponge plugin hosting site, not ready yet. Use the Sponge Forums instead.
Patreon
A Service that allows for donations to projects and organizations. If you want to support Sponge, this is the place to
look at! `Sponge Patreon Donation Page <https://www.patreon.com/Sponge?ty=h>`__
look at! `Sponge Patreon Donation Page <https://www.patreon.com/Sponge>`__
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may have been a value in the past, but I couldn't find any trace of it in the Patreon docs

@Inscrutable Inscrutable merged commit c0ebaea into stable Dec 3, 2017
@ST-DDT ST-DDT deleted the fix/https branch February 18, 2018 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants