Truncate logs #172
Merged
Truncate logs #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| unsigned long long fileLength = [handle seekToEndOfFile]; | ||
| if (fileLength <= MAX_LENGTH) return [RACSignal empty]; | ||
|
|
||
| [handle seekToFileOffset:fileLength - MAX_LENGTH]; |
There was a problem hiding this comment.
I don't love this, but I also couldn't find a better way to truncate from the start of a file. Since log messages are appended, we want to keep the most recent messages, i.e., the messages at the end.
There was a problem hiding this comment.
This doesn’t truncate in a line aware fashion which is a bummer, what do you think about taking the last N lines instead?
There was a problem hiding this comment.
I didn't figure it was worth the hassle. If we need to be line-aware, we either need to read the whole file (bummer if it's already big) or get a bit more complex. I'm not sure it's worth it.
There was a problem hiding this comment.
👌 lets roll with the minimum size
|
🍯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #170