-
-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop unittest2 #6187
Merged
Merged
Drop unittest2 #6187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cognifloyd
requested review from
amanda11,
guzzijones,
mamercad,
nzlosh,
winem and
a team
April 19, 2024 08:11
pull-request-size
bot
added
the
size/XL
PR that changes 500-999 lines. Consider splitting work into several ones that easier to review.
label
Apr 19, 2024
nzlosh
approved these changes
Apr 19, 2024
cognifloyd
force-pushed
the
drop-unittest2
branch
from
April 19, 2024 16:19
b9aa35f
to
ccdfb5d
Compare
Lockfile diff: lockfiles/st2.lock [st2] == Upgraded dependencies == argcomplete 3.2.3 --> 3.3.0 exceptiongroup 1.2.0 --> 1.2.1 gunicorn 21.2.0 --> 22.0.0 idna 3.6 --> 3.7 itsdangerous 2.1.2 --> 2.2.0 kombu 5.3.6 --> 5.3.7 orjson 3.10.0 --> 3.10.1 setuptools 69.2.0 --> 69.5.1 virtualenv 20.25.1 --> 20.25.3 == Removed dependencies == linecache2 1.0.0 traceback2 1.4.0 unittest2 1.1.0
pull-request-size
bot
added
size/XXL
PR that changes 1000+ lines. You should absolutely split your PR into several.
and removed
size/XL
PR that changes 500-999 lines. Consider splitting work into several ones that easier to review.
labels
Apr 19, 2024
It would probably be easiest to review each commit in order. |
amanda11
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
external dependency
size/XXL
PR that changes 1000+ lines. You should absolutely split your PR into several.
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks work by @nzlosh from #6157