Update pylint to 3.1.0 #6191
Merged
Update pylint to 3.1.0 #6191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cognifloyd
added
external dependency
infrastructure: ci/cd
maintenance
no changelog
pull-request-size
bot
added
the
size/L
Lockfile diff: lockfiles/pylint.lock [pylint] == Upgraded dependencies == astroid 2.5.6 --> 3.1.0 mccabe 0.6.1 --> 0.7.0 pylint 2.8.3 --> 3.1.0 setuptools 69.2.0 --> 69.5.1 == Added dependencies == dill 0.3.8 platformdirs 4.2.1 tomli 2.0.1 tomlkit 0.12.4 typing-extensions 4.11.0 == Removed dependencies == lazy-object-proxy 1.10.0 toml 0.10.2 wrapt 1.12.1
cognifloyd
force-pushed
the
pylint-update
branch
from
f61ddbe
to
480c34a
Compare
cognifloyd
commented
Apr 26, 2024
Use the source dictionary property to define the line/col numbers of the virtual/injected assign node, where the assign node includes both the name (use property name location) and the value (use property data location). So, the assign node starts at the start of property_name_node and ends at the end of the property_data_node. The assign_name_node just inherits the location of the property_name_node.
We are testing the value node of the assign node (where an assign node consists of a name and a value node: "name = value"). So, we need to use the location of the value node not the parent assign node.
nzlosh
approved these changes
Apr 26, 2024
amanda11
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts @nzlosh's pylint-related updates/fixes from #6157.