Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pytest #952

Merged
merged 31 commits into from
Apr 24, 2023
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
f6370c1
try new pytest maybe
steveri Apr 21, 2023
09e34ca
confused container and image
steveri Apr 21, 2023
9c9fce7
disable requirements.txt-based workflow test
steveri Apr 21, 2023
ad47210
must run pytest from garnet dir, duh
steveri Apr 21, 2023
f61fbad
activate correct python environment maybe
steveri Apr 21, 2023
0079267
lost our dir maybe
steveri Apr 21, 2023
adbe78a
install required package pytest-cov
steveri Apr 21, 2023
b3371a1
first step toward eliminating bad pytests
steveri Apr 22, 2023
1f105a9
wrong syntax for pytest skip
steveri Apr 22, 2023
b4846dd
on track now i think
steveri Apr 22, 2023
f3614c0
skip failing pont pytests
steveri Apr 22, 2023
04015d3
skip final two failing tests, all remaining tests should pass now
steveri Apr 22, 2023
107be1d
missed a "import pytest". huh.
steveri Apr 22, 2023
46bae64
final cleanup maybe
steveri Apr 22, 2023
0b7fcc4
last minute cleanup
steveri Apr 22, 2023
c6ca24f
trying out a new ci.yml for aha-flow regressions
steveri Apr 23, 2023
3b2cfa5
missed a double-quote
steveri Apr 23, 2023
50251e2
agents maybe?
steveri Apr 23, 2023
4bffd47
struggling with buildkite pipeline syntax :(
steveri Apr 23, 2023
31e4fc3
agent-specification troubles
steveri Apr 23, 2023
789f4a8
little debugging
steveri Apr 23, 2023
67de0fe
agents are not behaving!
steveri Apr 23, 2023
59344ea
./garnet => .
steveri Apr 23, 2023
f8c0680
resnet_tests => pr
steveri Apr 23, 2023
b61e1f2
image-prune experiments
steveri Apr 23, 2023
6e7f688
image-prune experiments
steveri Apr 23, 2023
02bb73b
image-prune experiments
steveri Apr 23, 2023
9da0997
image-prune experiments -- prune containers as well
steveri Apr 23, 2023
6c7c991
image-prune experiments -- prune containers as well II
steveri Apr 23, 2023
2aaa744
ci.yml final form maybe
steveri Apr 23, 2023
9fbc6f9
An attempt at deprecating requirements.txt in favor of pre-built docker
steveri Apr 24, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
last minute cleanup
  • Loading branch information
steveri committed Apr 22, 2023
commit 0b7fcc420765ce242de07fa2085bf3d7832a995f
21 changes: 2 additions & 19 deletions .github/workflows/pytest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,14 @@ jobs:

steps:
- uses: actions/checkout@v2

- name: Checkout submodules
shell: bash
run: |
auth_header="$(git config --local --get http.https://github.com/.extraheader)"
git submodule sync --recursive
git -c "http.extraheader=$auth_header" -c protocol.version=2 submodule update --init --force --recursive --depth=1

- name: Pull and run docker 🐋
shell: bash
run: |
Expand All @@ -34,16 +36,6 @@ jobs:
docker exec CONTAINER /bin/bash -c "rm -rf /aha/garnet"
docker cp ../garnet CONTAINER:/aha/garnet

# - name: Install deps 🛠️
# shell: bash
# run: |
# docker exec -i garnet bash -c "apt update"
# docker exec -i garnet bash -c "apt install -y default-jre"
# docker exec -i garnet bash -c "pip install -r /garnet/requirements.txt"
# docker exec -i garnet bash -c "pip install coveralls"
# docker exec -i garnet bash -c "pip install pytest"
# docker exec -i garnet bash -c "pip install pytest-cov pytest-pycodestyle z3-solver genesis2"

- name: Run tests ⚙️
shell: bash
run: |
Expand All @@ -54,12 +46,3 @@ jobs:
# CODECOV_TOKEN secret stored at https://github.com/StanfordAHA/garnet/settings/secrets/actions
run: |
docker exec -i CONTAINER bash -c "cd /aha/garnet/ && bash <(curl -s https://codecov.io/bash) -t ${{ secrets.CODECOV_TOKEN }}"



# if [ $use_local_garnet == True ]; then
# docker exec $container_name /bin/bash -c "rm -rf /aha/garnet"
# # Clone local garnet repo to prevent copying untracked files
# git clone $GARNET_HOME ./garnet
# docker cp ./garnet $container_name:/aha/garnet
# fi