Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bevy 0.10 #396

Closed
wants to merge 2 commits into from
Closed

Bevy 0.10 #396

wants to merge 2 commits into from

Conversation

johanhelsing
Copy link
Contributor

@johanhelsing johanhelsing commented Mar 5, 2023

Makes basic example work with latest bevy

  • switch to bevy 0.10 when out
  • fix the rest of the examples
  • figure out if I got the mip_levels right

@geieredgar
Copy link
Contributor

I am sorry for not having chosen a better name, but I did already port the codebase to bevy 0.10 here: #390. I've added the (0.10) suffix now. All examples are already ported. I used gpu_texture.mip_level_count() for the mip level count instead of a hard coded 1.

@geieredgar
Copy link
Contributor

geieredgar commented Mar 6, 2023

My pull request targets the bevy_track branch, because I hoped it could then be pulled earlier without disturbing main (Edit: I forgot I did already change that). And unlike you, I don't have the rights to start work flows. Would you mind if I open a PR for your fork and then you can use it to open a PR here for the main branch?

@johanhelsing
Copy link
Contributor Author

Ah, bummer. Don't know why I didn't see it. I'll let you continue on yours then 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants