Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Warn users on possible risks on installing third party unvetted plugins #600

Closed
wants to merge 39 commits into from
Closed

[Feature] Warn users on possible risks on installing third party unvetted plugins #600

wants to merge 39 commits into from

Conversation

RodoMa92
Copy link
Contributor

Please tick as appropriate:

  • I have tested this code on a steam deck or on a PC
  • My changes generate no new errors/warnings
  • This is a bugfix/hotfix
  • This is a new feature

Description

This PR implements proper warning messages for third party install outside our store to warn users of potential malicious code outside our ecosystem.

AAGaming00 and others added 30 commits November 9, 2023 15:35
@AAGaming00
fix: get rid of title view jank on latest beta
29d651b
@PartyWumpus
Count the number of installs for each plugin (SteamDeckHomebrew#557)
8f26fde
@dependabot
Bump aiohttp from 3.8.4 to 3.8.5 in /backend (SteamDeckHomebrew#558)
479a16c
@Jan200101
Check if Linux service is running before trying to start or stop it (S…
75ad98a 
…teamDeckHomebrew#540)

this prevents needless prompts opening up
@Jan200101
replace chmod implementation with os.chmod (SteamDeckHomebrew#541)
7c3ae9b
@PartyWumpus
bump dfl
91186da
@AAGaming00
fix: Adjust tabs and toaster hooks to work on react 18, also half-fix…
80a00a0 
… Valve Internal
@AAGaming00
fix: idiotic formatting error i should have noticed
e21a5d5
@AAGaming00
fix(developer): add back valve internal on beta
3489fd7 
look i was tired when writing yesterday's fix okay
@Jan200101
Call plugin unload function after stopping event loop (SteamDeckHomeb…
39f4f28 
…rew#539)

This can prevent race conditions where unload is clearing data but main is still working with it
@WerWolvTranslationBot @Tak-attack
@weblate @foliveira
Translations update from Weblate (SteamDeckHomebrew#553)
e3d72b6 
* Added translation using Weblate (Japanese)

* Update translation files

Updated by "Remove blank strings" hook in Weblate.

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/

* Update translation files

Updated by "Remove blank strings" hook in Weblate.

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/

* Update translation files

Updated by "Remove blank strings" hook in Weblate.

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/

* Update translation files

Updated by "Remove blank strings" hook in Weblate.

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/

* Update translation files

Updated by "Remove blank strings" hook in Weblate.

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/

* Update translation files

Updated by "Remove blank strings" hook in Weblate.

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/

* Update translation files

Updated by "Remove blank strings" hook in Weblate.

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/

* Update translation files

Updated by "Remove blank strings" hook in Weblate.

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/

* Translated using Weblate (Japanese)

Currently translated at 82.7% (115 of 139 strings)

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ja/

* Translated using Weblate (Japanese)

Currently translated at 89.2% (124 of 139 strings)

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ja/

* Translated using Weblate (Japanese)

Currently translated at 100.0% (139 of 139 strings)

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ja/

* Translated using Weblate (Portuguese (Portugal))

Currently translated at 100.0% (139 of 139 strings)

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/pt_PT/

* Translated using Weblate (Portuguese (Brazil))

Currently translated at 100.0% (139 of 139 strings)

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/pt_BR/

---------

Co-authored-by: Tak-attack <tak.bts@gmail.com>
Co-authored-by: Weblate <noreply@weblate.org>
Co-authored-by: Fábio Oliveira <fabio.an.oliveira@gmail.com>
@dependabot
Bump tj-actions/changed-files to 41.0.0 in /.github/workflows (SteamD…
12a99b8 
…eckHomebrew#575)

Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 35.6.3 to 41.0.0.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@v35.6.3...v41.0.0)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@beebls @suchmememanyskill
fix: Fix on Chromium 109 beta (SteamDeckHomebrew#576)
f9a07da 
* Add new user agent to do not close tabs list

* fix: bump DFL to fix chromium 109 beta

---------

Co-authored-by: Sims <38142618+suchmememanyskill@users.noreply.github.com>
@dependabot
Bump aiohttp from 3.8.5 to 3.9.0 in /backend (SteamDeckHomebrew#577)
9295e4b
@RodoMa92
[Bugfix] Toaster changed name again (SteamDeckHomebrew#581)
3146ebf 
Add another name placeholder for getting the toaster out of the HTML tree. Thanks to @eXhumer for the fix.
@WerWolvTranslationBot @Tak-attack
@weblate @foliveira
Translations update from Weblate (SteamDeckHomebrew#580)
647f3fe 
* Added translation using Weblate (Japanese)

* Update translation files

Updated by "Remove blank strings" hook in Weblate.

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/

* Update translation files

Updated by "Remove blank strings" hook in Weblate.

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/

* Update translation files

Updated by "Remove blank strings" hook in Weblate.

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/

* Update translation files

Updated by "Remove blank strings" hook in Weblate.

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/

* Update translation files

Updated by "Remove blank strings" hook in Weblate.

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/

* Update translation files

Updated by "Remove blank strings" hook in Weblate.

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/

* Update translation files

Updated by "Remove blank strings" hook in Weblate.

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/

* Update translation files

Updated by "Remove blank strings" hook in Weblate.

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/

* Translated using Weblate (Japanese)

Currently translated at 82.7% (115 of 139 strings)

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ja/

* Translated using Weblate (Japanese)

Currently translated at 89.2% (124 of 139 strings)

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ja/

* Translated using Weblate (Japanese)

Currently translated at 100.0% (139 of 139 strings)

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ja/

* Translated using Weblate (Portuguese (Portugal))

Currently translated at 100.0% (139 of 139 strings)

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/pt_PT/

* Translated using Weblate (Portuguese (Brazil))

Currently translated at 100.0% (139 of 139 strings)

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/pt_BR/

---------

Co-authored-by: Tak-attack <tak.bts@gmail.com>
Co-authored-by: Weblate <noreply@weblate.org>
Co-authored-by: Fábio Oliveira <fabio.an.oliveira@gmail.com>
@AAGaming00
fix the tasks
6b4a56c
@AAGaming00
fix: use findInReactTree to find correct errorboundary for toaster
7f2caa3 
fixes toaster error on latest beta
@AAGaming00
fix: bump dfl to fix error on latest steam beta
62e3128
@PartyWumpus
Specify catthehacker/ubuntu:act-22.04 as container for act
3e4c255 
Fixes an issue where act wouldn't use the correct container and so couldn't find a compatible python version, so it would fail to build.
@PartyWumpus
Refactor plugin store and add sorting by downloads and release date (S…
fd4ed81 
…teamDeckHomebrew#547)

* untested first commit

* fix types & names

* comment out built in sorting for now

* rerun search when sort changes

* fix ts complaints

* use prettier

* stop switch-case fall through

* move spinner

* use locale instead of hardcoded string

* fix typo

* add sorting by downloads & try using the data field in the dropdown for data

* fix typing error

* fix asc/desc in dropdown

* fix asc/desc again. asc = smaller one go first aaaaa

* I don't think i know what ascending means maybe

* use props instead of children, like a normal component
@PartyWumpus
Revert "Call plugin unload function after stopping event loop (SteamD…
2500b74 
…eckHomebrew#539)" (SteamDeckHomebrew#584)

This reverts commit 39f4f28 , because functions (seemingly) don't run after the event loop closes, so the unload function is never actually run.
@doZennn
fix(filepicker_ls): use case insensitive matching for file exts (Stea…
435dfa7 
…mDeckHomebrew#585)
@PartyWumpus @RodoMa92
Testing PRs from within decky (SteamDeckHomebrew#496)
9503d5c 
* git no work so manually uploading files :(

* argh i wish git was working

* ok next time i'll make git work

* Update updater.py

* git please work next time this took ages without you

* fix me locales

* Update updater.py

* Update en-US.json

* Update updater.py

* Update updater.py

* i wish my python LSP stuff was working

* fix it

* Update updater.py

* Update updater.py

* Only show testing branch as an option if it is already selected

* Initial implementation for fetching the open PRs. Still need testing and a token to complete this.

* Wrong filter capitalization

* Fix a couple of typos in the python backend updater.

* Fix typos pt 3

* This should be the last one

* Prepend the PR version number with PR- to make it clearer that's the PR number.

* Update prettier to the latest version otherwise it will never be happy with the formatting.

* fix merge mistake

* fix pyright errors & type hint most new code

* fix strict pyright errors...

* not sure why my local linter didn't catch this

* Reimplement the logic between PR and artifact build to limit API calls

* Fix pyright errors

* use nightly.link for downloads

* remove accidental dollar sign

* fix various logical errors. the code actually works now.

* set branch to testing when user downloads a testing version

---------

Co-authored-by: Marco Rodolfi <marco.rodolfi@tuta.io>
@eXhumer
Get plugin name for development ZIP during installation (SteamDeckHom…
0dce3a8 
…ebrew#578)

* fix: get plugin name for dev builds from ZIP (SteamDeckHomebrew#527)

Signed-off-by: eXhumer <exhumer1@protonmail.com>
@FineWolf
[Feature] Freeze updates for devs (SteamDeckHomebrew#582)
7d6b880
@PartyWumpus
fix finding qam root node for feb 14th beta
ecf4800
@PartyWumpus
Appease prettier
922d0c4 
i must have done a great deal of harm in a past life to deserve this mistreatment by formatting tools. why do they hate me.
@WerWolvTranslationBot @Tak-attack
@weblate @foliveira @FineWolf @danae @RodoMa92
Translations update from Weblate (SteamDeckHomebrew#587)
49d1e33 
* Added translation using Weblate (Japanese)

* Update translation files

Updated by "Remove blank strings" hook in Weblate.

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/

* Update translation files

Updated by "Remove blank strings" hook in Weblate.

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/

* Update translation files

Updated by "Remove blank strings" hook in Weblate.

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/

* Update translation files

Updated by "Remove blank strings" hook in Weblate.

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/

* Update translation files

Updated by "Remove blank strings" hook in Weblate.

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/

* Update translation files

Updated by "Remove blank strings" hook in Weblate.

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/

* Update translation files

Updated by "Remove blank strings" hook in Weblate.

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/

* Update translation files

Updated by "Remove blank strings" hook in Weblate.

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/

* Translated using Weblate (Japanese)

Currently translated at 82.7% (115 of 139 strings)

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ja/

* Translated using Weblate (Japanese)

Currently translated at 89.2% (124 of 139 strings)

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ja/

* Translated using Weblate (Japanese)

Currently translated at 100.0% (139 of 139 strings)

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ja/

* Translated using Weblate (Portuguese (Portugal))

Currently translated at 100.0% (139 of 139 strings)

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/pt_PT/

* Translated using Weblate (Portuguese (Brazil))

Currently translated at 100.0% (139 of 139 strings)

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/pt_BR/

* Translated using Weblate (French)

Currently translated at 91.3% (127 of 139 strings)

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/fr/

* Translated using Weblate (Dutch)

Currently translated at 100.0% (139 of 139 strings)

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/nl/

* Translated using Weblate (English)

Currently translated at 100.0% (147 of 147 strings)

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/en/

* Translated using Weblate (Italian)

Currently translated at 100.0% (147 of 147 strings)

Translation: Decky/Decky
Translate-URL: https://weblate.werwolv.net/projects/decky/decky/it/

---------

Co-authored-by: Tak-attack <tak.bts@gmail.com>
Co-authored-by: Weblate <noreply@weblate.org>
Co-authored-by: Fábio Oliveira <fabio.an.oliveira@gmail.com>
Co-authored-by: Andrew Moore <andrewm.finewolf@gmail.com>
Co-authored-by: Danae Dekker <genecyll@gmail.com>
Co-authored-by: Marco Rodolfi <marco.rodolfi@tuta.io>
@TrainDoctor
Update bug_report.yml
55a95e0
@RodoMa92 RodoMa92 changed the title Warn third party Warn users on possible risks on installing third party unvetted plugins Mar 13, 2024
@RodoMa92 RodoMa92 changed the title Warn users on possible risks on installing third party unvetted plugins [Feature] Warn users on possible risks on installing third party unvetted plugins Mar 13, 2024
JohnnyCrazy
JohnnyCrazy approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@JohnnyCrazy JohnnyCrazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

I think the TranslationHelper might be doing too much tho and grow into oblivion, maybe separate functions/helpers in the components would be better in the long term.

EMERALD0874
EMERALD0874 reviewed Mar 14, 2024
View reviewed changes
Copy link
Member

@EMERALD0874 EMERALD0874 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some non-blocking requested changes regarding the language, but the code changes look great!

backend/locales/en-US.json Outdated Show resolved Hide resolved
backend/locales/en-US.json Outdated Show resolved Hide resolved
backend/locales/en-US.json Outdated Show resolved Hide resolved
backend/locales/en-US.json Outdated Show resolved Hide resolved
backend/locales/en-US.json Outdated Show resolved Hide resolved
@RodoMa92
Copy link
Contributor Author

Nice, LGTM!

I think the TranslationHelper might be doing too much tho and grow into oblivion, maybe separate functions/helpers in the components would be better in the long term.

Yeah, I agree, I just need to find a decent place to place them without adding too much clutter in the structure of the project. I'll probably do this not too far down the line.

@TrainDoctor TrainDoctor added the enhancement New feature or request label Aug 6, 2024
@TrainDoctor
Copy link
Member

@RodoMa92 do you want to proceed with these changes or would refactoring to latest main be to difficult?

@RodoMa92
Copy link
Contributor Author

RodoMa92 commented Aug 9, 2024

I'll close my two PRs and will readd them on top, too much changes on top of main to cleanly rebase them.

@RodoMa92 RodoMa92 closed this Aug 9, 2024
@RodoMa92 RodoMa92 deleted the warn_third_party branch August 9, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EMERALD0874 EMERALD0874 EMERALD0874 left review comments

@JohnnyCrazy JohnnyCrazy JohnnyCrazy approved these changes

Assignees

@RodoMa92 RodoMa92

Labels
enhancement New feature or request
Projects
SDH Tracker
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.