Full support for desktop Steam UI #712
Open
+1,563
−198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
works well enough lol
AAGaming00
force-pushed
the
aa/desktop-routerhook
branch
from
7e040c1
to
fa4c4a7
Compare
AAGaming00
added
enhancement
PartyWumpus
reviewed
Oct 5, 2024
Comment on lines
27
to
+28
| Navigation.CloseSideMenus(); | ||
| setDesktopMenuOpen(false); |
There was a problem hiding this comment.
This shouldn't be needed, we should modify Navigation.CloseSideMenus() to close the desktop menu. Def needed because plugins close side menus too all the time
| @@ -87,10 +105,10 @@ class RouterHook extends Logger { | |||
| this.patchGamepadRouter(); | |||
| break; | |||
| // Not fully implemented yet | |||
Comment on lines
+1
to
+4
| export enum UIMode { | ||
| BigPicture = 4, | ||
| Desktop = 7, | ||
| } |
| } | ||
|
|
||
| export class DeckyRouterState { | ||
| private _routes = new Map<string, RouterEntry>(); | ||
| private _routePatches = new Map<string, Set<RoutePatch>>(); | ||
| // Update when support for new UIModes is added |
There was a problem hiding this comment.
What other UIModes are there? I guess SteamVR might be seperate from BPM?
There was a problem hiding this comment.
I have no idea how vr works but I plan to look into it soon
it'll be interesting as it can run at the same time as the desktop ui
Comment on lines
+84
to
+85
| Navigation.OpenQuickAccessMenu(QuickAccessTab.Decky); | ||
| DeckyPluginLoader.setDesktopMenuOpen(true); |
There was a problem hiding this comment.
Similar to above comment, we could make OpenQuickAccessMenu open the desktop menu but eeh i don't know if any plugins use it, and it only makes sense for the decky tab so not really sure.
Co-authored-by: Party Wumpus <48649272+PartyWumpus@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please tick as appropriate:
Description
This PR adds full feature parity between desktop and gamepad UI modes. The styling is a bit rough, but it's fully functional.
Video
Also includes some React DevTools fixes.