Document default permissions for tempdirs #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
reviewed
Aug 10, 2024
src/lib.rs
Outdated
| @@ -347,6 +346,8 @@ impl<'a, 'b> Builder<'a, 'b> { | |||
| /// # Platform Notes | |||
| /// ## Unix | |||
| /// | |||
| /// Tempfiles default to `0o600` and temdirs default to `0o777`. | |||
There was a problem hiding this comment.
This should be combined with the next sentence for clarity and should explain how the umask is combined. The reader needs to walk away understanding that, by default, the permissions on a directory are 0o755 given the standard 0o022 umask, etc.
Also, it should mention Builder::permissions.
There was a problem hiding this comment.
Oh, wait. This is Builder::permissions(). Never mind that part.
But I still want the reader to come away with an understanding that their temporary directory is probably not going to be world-writable.
There was a problem hiding this comment.
I tried to incorporate this, but further notes on it would be welcome.
Fixes implying that the default is the same as the one for tempfiles
Imberflur
force-pushed
the
default-permissions-docs
branch
from
d71544c
to
1e943d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #284