Hardhat network configuration should not contain url property

Modified conditional clause for disallowing undefined url property of Hardhat network at the networks configuration object
StillFantastic · Dec 20, 2020 · 7b9601e · 7b9601e
1 parent eab324a
commit 7b9601e
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/packages/hardhat-core/src/internal/core/config/config-validation.ts b/packages/hardhat-core/src/internal/core/config/config-validation.ts
@@ -225,7 +225,7 @@ export function getValidationErrors(config: any): string[] {
   if (config !== undefined && typeof config.networks === "object") {
     const hardhatNetwork = config.networks[HARDHAT_NETWORK_NAME];
     if (hardhatNetwork !== undefined) {
-      if (hardhatNetwork.url !== undefined) {
+      if (hardhatNetwork.hasOwnProperty("url")) {
         errors.push(
           `HardhatConfig.networks.${HARDHAT_NETWORK_NAME} can't have an url`
         );

diff --git a/packages/hardhat-core/test/internal/core/config/config-validation.ts b/packages/hardhat-core/test/internal/core/config/config-validation.ts
@@ -689,6 +689,20 @@ describe("Config validation", function () {
             assert.isEmpty(errors);
           });
 
+          it("Should fail if url is set for hardhat network (undefined)", function () {
+            const errors = getValidationErrors({
+              networks: { [HARDHAT_NETWORK_NAME]: { url: undefined } },
+            });
+            assert.isNotEmpty(errors);
+          });
+
+          it("Should fail if url is set for hardhat network", function () {
+            const errors = getValidationErrors({
+              networks: { [HARDHAT_NETWORK_NAME]: { url: "anyurl" } },
+            });
+            assert.isNotEmpty(errors);
+          });
+
           it("Shouldn't fail if no url is set for hardhat network", function () {
             const errors = getValidationErrors({
               networks: { [HARDHAT_NETWORK_NAME]: {} },