This repository has been archived by the owner on Jun 4, 2021. It is now read-only.
Update to Ansible 2.4 syntax #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 14, 2017
Closed
|
Hmm, I had a full run of the playbook on a fresh EC2 instance and no problems were found. The CI still uses Ansible 2.3 so it fails the version check. |
wzyboy
force-pushed
the
feature/ansible-2.4
branch
from
2b808de
to
e2e4f6d
Compare
|
Ansible version in CI is now updated to 2.4 as well, along with the |
|
Thanks for taking this on @wzyboy - I will review shortly. |
The "include" syntax to include a task is deprecated in 2.4.
wzyboy
force-pushed
the
feature/ansible-2.4
branch
from
831e119
to
461457b
Compare
|
Resolved conflicts and rebased. |
cpu
approved these changes
Oct 14, 2017
|
@wzyboy Perfect! Thanks for the quick update. I'll merge this once the CI completes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates
includesyntax toimport_tasksinclude_tasksimport_playbook, and raises the required version of Ansible to 2.4.I have tested this on a fresh EC2 instance, all went well.
Ref: #994