Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use .net core sdk 1.0 rtm #590

Merged
merged 17 commits into from
Mar 23, 2017
Merged

Conversation

enricosada
Copy link
Contributor

the Microsoft.FSharp.Core.netcore is deprecated to use directly.
use the FSharp.Core package, v4.1 now support netstandard1.6

@enricosada enricosada changed the title use FSharp.Core package instead of Microsoft.FSharp.Core.netcore [WIP] use FSharp.Core package instead of Microsoft.FSharp.Core.netcore Mar 16, 2017
@enricosada
Copy link
Contributor Author

let me test this a bit more 😄 , because a new drop of fsharp.core is near, just to be sure

@haf
Copy link
Contributor

haf commented Mar 16, 2017

Of course :)

@enricosada
Copy link
Contributor Author

@haf i'll just convert everything to sdk 1.0 rtm and new fsproj

@enricosada enricosada changed the title [WIP] use FSharp.Core package instead of Microsoft.FSharp.Core.netcore use .net core sdk 1.0 rtm Mar 22, 2017
@enricosada
Copy link
Contributor Author

enricosada commented Mar 22, 2017

@ademar @haf i think is ok.

  • i migrate to .net core sdk 1.0 (so fsproj instead of project.json).
  • use FSharp,Core instead of MS.Fsharp.Core.netcore (deprecated)
  • fixed build script (with update install script)
  • tested locally
  • tested it with https://github.com/SuaveIO/Suave-CoreCLR-sample too (updated)

i did not test the install script on osx/ubuntu, but now is the same as windows

error on travis is not mine i think

@ademar ademar merged commit 809e6d0 into SuaveIO:master Mar 23, 2017
@ademar
Copy link
Member

ademar commented Mar 23, 2017

Thanks Enrico, much appreciated!

@enricosada
Copy link
Contributor Author

np @ademar, any issue feel free to ping me directly.
If is possibile to have a Suave 2.0.5-alpha of this, will be really helpful, because we are trying to move FsAutocomplete to full .net core.
Atm i cannot use 2.0.4 because it depends on MS.Fsharp.Core.netcore nupkg, so i cannot mix it with other packages using Fsharp.Core 4.1 nupkg, otherwise i get two FSharp.Core.dll referenced 😄

That will enable all FSAC based tools (vscode/emac/vi) to run with just .net core installed (without .net or mono required)

@ademar
Copy link
Member

ademar commented Mar 23, 2017

Sure thing, I'll get to it

@ademar
Copy link
Member

ademar commented Mar 23, 2017

@enricosada just pushed 2.0.5-alpha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants