-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests under NetCore #671
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is very very cool, thank you very much :) |
@alex-bogomaz can we merge this one ? |
Yes - we can merge. Netcore tests still depend on net46 "HTTP.fs", but it is OK, since netcore supports referencing full-framework libraries (as long as they work). |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
*.netcore.fsproj
to 2.0 SDKSuave.LibUv
tonetstandard 2.0
, becase some APIs are missing innetstandard 1.6
(likeBeginThreadAffinity
and others)netcoreapp 2.0
(noWebSocketSharp
andSuave.LibUv
fornetstandard 1.6
)Notes:
Http.fs
- need to wait for NetCore release. Now using full-framework package. //cc @seanamos and @ivpadimReason: some tests (which start and stop server) are failing with "Default TCP engine" - it is not possible on Linux to dispose socket and re-bind - https://github.com/dotnet/corefx/issues/24562.
We can do something similar as for Kestrel: aspnet/KestrelHttpServer#2111, but this requires building Suave for
netstandard 2.0
, since there are noHandle
property forSocket
under 1.6.Three
Auth.fs
tests are excluded because Suave cookie serialization code fails to serializeFSharpMap
. Probably that code should not useDataContractJsonSerializer
and use Newtonsoft instead?After converting to 2.0 SDK - there are a lot of build warnings like
but according to this dotnet/standard#505 we may skip those warnings