Remove unnecessary random-int package

Subash · Jan 12, 2022 · bac342c · bac342c
1 parent 923730a
commit bac342c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 9 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -35,8 +35,7 @@
   "dependencies": {
     "commander": "^6.1.0",
     "is-ip": "^3.1.0",
-    "node-forge": "^0.10.0",
-    "random-int": "^2.0.1"
+    "node-forge": "^0.10.0"
   },
   "devDependencies": {
     "jest": "^26.4.2"

diff --git a/src/mkcert.js b/src/mkcert.js
@@ -1,12 +1,12 @@
 const isIp = require('is-ip');
 const forge = require('node-forge');
 const { promisify } = require('util');
-const randomInt = require('random-int');
 const pki = forge.pki;
 const generateKeyPair = promisify(pki.rsa.generateKeyPair.bind(pki.rsa));
 
 async function generateCert({ subject, issuer, extensions, validityDays, signWith }) {
-  const serial = randomInt(50000, 99999).toString();
+  // create serial from and integer between 50000 and 99999
+  const serial = Math.floor((Math.random() * 95000) + 50000).toString();
   const keyPair = await generateKeyPair({ bits: 2048, workers: 4 });
   const cert = pki.createCertificate();