Cleaned up build scripts and used AssemblyResolve event instead of copying all dlls #1098
Conversation
|
Hello how i can download your version of nitrox to run my server with your version to test if the buildings works properly ? |
@ZachTaMere Can you please wait until the next nitrox release, It's a workplace here and If you have questions about Nitrox please join our Discord so our support team can answer to them. Best regards |
| public static NitroxVector3 ToDto(this Vector3 v) | ||
| { | ||
| return new NitroxVector3(v.x, v.y, v.z); | ||
| } | ||
|
|
There was a problem hiding this comment.
Maybe rename it to ToNitrox() to correspond to ToUnity()?
There was a problem hiding this comment.
I'd like to keep this ambiguous and not Nitrox specific in case we want to extend this to external services (outside of Nitrox).
There was a problem hiding this comment.
Ok, after your message in discord I know the meaning and I am fine with it :)
There was a problem hiding this comment.
What was the justification? toNitrox() may be more intuitive to those not in the industry. Also, the method does return a NitroxVector3.
There was a problem hiding this comment.
What does "Dto" mean?
Maybe better use .ToUnityVector() and .ToNitroxVector() ? Then it should be clear enough what this method concrete does and not be too ambigous to confound with other "ToNitrox" conversions.
There was a problem hiding this comment.
@acidscorch ToDto means To data transfer object which is often used for such "data conversation". ToNitroxVector is (imo) too complicated because you already use it on a type like NitroxVector. I would just wait for @Sunrunner37 s opinion.
There was a problem hiding this comment.
@Jannify Ah yes, i understand. (Sorry i'm not very familiar with extension methods.)
This Method is for converting a UnityVector to a NitroxVector, correct? And you already have a .ToUnity() Method. Maybe then use .FromUnity() for this?
| public static NitroxVector3 ToDto(this Vector3 v) | ||
| { | ||
| return new NitroxVector3(v.x, v.y, v.z); | ||
| } | ||
|
|
There was a problem hiding this comment.
What was the justification? toNitrox() may be more intuitive to those not in the industry. Also, the method does return a NitroxVector3.
NitroxModel-Subnautica/DataStructures/Surrogates/QuaternionSurrogate.cs
Outdated
Show resolved
Hide resolved
NitroxServer-Subnautica/Serialization/SubnauticaServerProtoBufSerializer.cs
Show resolved
Hide resolved
|
I went with |
…ne as possible for now
Added shared project for copying the resources to the launcher output
…blies as byte arrays
…ause it's in Directory.Build.props
…ne reference free
…of relying on appdata file
Nitrox.Bootloaderproject that loads Nitrox based on where the launcher is located. The path is stored in "%AppData%\Roadming\Nitrox\launcherpath.txt" when Subnautica is started through the launcher.Nitrox.Bootloader.dllis the only DLL that is copied to Subnautica managed directory.Directory.Build.targetsandDirectory.Build.propswhich MSBuild automatically includes in all projects.