Refactor for objects #1209
Closed
Refactor for objects #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killzoms
force-pushed
the
refactorForObjects
branch
2 times, most recently
from
c5b8f62
to
69e68e1
Compare
Coding-Hen
reviewed
Aug 9, 2020
NitroxClient/Communication/NetworkingLayer/LiteNetLib/LiteNetLibClient.cs
Outdated
Show resolved
Hide resolved
NitroxClient/Communication/NetworkingLayer/LiteNetLib/LiteNetLibClient.cs
Outdated
Show resolved
Hide resolved
NitroxClient/Communication/NetworkingLayer/LiteNetLib/LiteNetLibClient.cs
Outdated
Show resolved
Hide resolved
NitroxClient/Communication/Packets/Processors/ModuleAddedProcessor.cs
Outdated
Show resolved
Hide resolved
NitroxClient/Communication/Packets/Processors/ModuleAddedProcessor.cs
Outdated
Show resolved
Hide resolved
...-Subnautica/DataStructures/GameLogic/Buildings/Rotation/SubnauticaRotationMetadataFactory.cs
Outdated
Show resolved
Hide resolved
| @@ -22,7 +22,8 @@ public static bool Prefix(ExosuitClawArm __instance) | |||
| if (pickupable != null && pickupable.isPickupable && componentInParent.storageContainer.container.HasRoomFor(pickupable)) | |||
| { | |||
| NitroxServiceLocator.LocateService<Item>().PickedUp(pickupable.gameObject, pickupable.GetTechType()); | |||
| } else if(component != null) | |||
| } | |||
| else if (component != null) | |||
There was a problem hiding this comment.
Suggested change
| else if (component != null) | |
| else if (component) |
There was a problem hiding this comment.
If this is nullable, you'll need to if (component == true).
| @@ -12,14 +11,20 @@ public void Prepare(Entity parentEntity, DeterministicBatchGenerator determinist | |||
| { | |||
| Entity crashFish = SpawnChild(parentEntity, deterministicBatchGenerator, TechType.Crash, "7d307502-46b7-4f86-afb0-65fe8867f893"); | |||
| crashFish.Transform.LocalRotation = new NitroxQuaternion(-0.7071068f, 0, 0, 0.7071068f); | |||
| parentEntity.ChildEntities.Add(crashFish); | |||
| //parentEntity.ChildEntities.Add(crashFish); | |||
There was a problem hiding this comment.
I assume this can be removed then
dartasen
reviewed
Aug 19, 2020
NitroxClient/Communication/Packets/Processors/PDAScannerEntryProgressProcessor.cs
Outdated
Show resolved
Hide resolved
NitroxModel/MultiplayerSession/MultiplayerSessionReservationState.cs
Outdated
Show resolved
Hide resolved
NitroxClient/Communication/MultiplayerSession/MultiplayerSessionConnectionStage.cs
Outdated
Show resolved
Hide resolved
killzoms
force-pushed
the
refactorForObjects
branch
from
c669002
to
1fca0a6
Compare
killzoms
force-pushed
the
refactorForObjects
branch
from
1fca0a6
to
b4a0724
Compare
Co-authored-by: Coding-Hen <drhen123@googlemail.com>
killzoms
force-pushed
the
refactorForObjects
branch
from
c3e6058
to
640a128
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1182