Improved Nitrox loading logging #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jannify
reviewed
Aug 18, 2020
Jannify
approved these changes
Aug 18, 2020
Dessix
suggested changes
Aug 18, 2020
NitroxPatcher/Main.cs
Outdated
Comment on lines
58
to
60
| catch (Exception) | ||
| { | ||
| Log.Error("Error while initializing and loading dependencies."); |
There was a problem hiding this comment.
Suggested change
| catch (Exception) | |
| { | |
| Log.Error("Error while initializing and loading dependencies."); | |
| catch (Exception ex) | |
| { | |
| Log.Error(ex, "Error while initializing and loading dependencies."); |
Use public static void Error(Exception ex, string message) => logger.Error(ex, message); method variant.
NitroxPatcher/Main.cs
Outdated
| @@ -28,16 +32,34 @@ public static void Execute() | |||
| { | |||
| Log.Setup(true); | |||
| Optional.ApplyHasValueCondition<Object>(o => (bool)o); | |||
There was a problem hiding this comment.
Potentially explicitly use UnityEngine.Object and remove the using Object = UnityEngine.Object to avoid possible conflation with C#'s object?
Dessix
approved these changes
Aug 19, 2020
Coding-Hen
approved these changes
Aug 19, 2020
dartasen
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes issue where Launcher stays stuck when you try to close it due to trying to win32 postmessage on a dead process. So now just set it to
nullafter disposing and check for that.