Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated to new csproj format #1677

Merged
merged 5 commits into from
Dec 20, 2021
Merged

Migrated to new csproj format #1677

merged 5 commits into from
Dec 20, 2021

Conversation

Measurity
Copy link
Collaborator

@Measurity Measurity commented Dec 19, 2021 •
edited
Loading

TODO:

  • Fix NitroxServer-Subnautica unable to be started through NitroxLauncher due to reference issue.
  • Fix type load exception in packet.cs when running Nitrox.Test tests.

Other changes:

  • Removed LiteNetLib submodule in favor of NuGet package.
  • Removed Nitrox.Bootloader project because I found a way to load NitroxPatcher directly and still resolve DLL dependencies.

@Measurity Measurity force-pushed the sdk-csproj branch 3 times, most recently from b78054f to 7df8594 Compare December 19, 2021 17:31
@Measurity Measurity force-pushed the sdk-csproj branch 2 times, most recently from bfeb0ec to 1560c18 Compare December 19, 2021 23:04
@Measurity
Removed Nitrox.Bootloader project
d3bb520 
Found a way to use NitroxPatcher as entrypoint while still being able to resolve DLL dependencies dynamically from either Nitrox Launcher location or game location.
@Measurity Measurity marked this pull request as ready for review December 20, 2021 00:22
Jannify
Jannify approved these changes Dec 20, 2021
View reviewed changes
Copy link
Member

@Jannify Jannify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did building and starting of launcher, client and server. All went fine.

@Measurity Measurity merged commit 6a01ffb into SubnauticaNitrox:master Dec 20, 2021
@Measurity Measurity deleted the sdk-csproj branch December 20, 2021 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jannify Jannify Jannify approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Measurity @Jannify