Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added server check for invalid username #1706

Merged
merged 2 commits into from
Feb 1, 2022
Merged

Added server check for invalid username #1706

merged 2 commits into from
Feb 1, 2022

Conversation

dartasen
Copy link
Member

This check is only client side for now, which can be problematic with evil persons

@dartasen dartasen requested a review from Jannify January 14, 2022 23:42
Jannify
Jannify approved these changes Jan 16, 2022
View reviewed changes
Copy link
Member

@Jannify Jannify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise seems fine. I didn't do any in-game testing, I believe you did for sure.

@Measurity Measurity merged commit d46ce65 into SubnauticaNitrox:master Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jannify Jannify Jannify approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dartasen @Jannify @Measurity