Adding a way to specify the installation path through environment variables #1727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jannify
reviewed
Feb 9, 2022
NitroxModel/Discovery/InstallationFinders/EnvironmentGameFinder.cs
Outdated
Show resolved
Hide resolved
Measurity
reviewed
Feb 9, 2022
NitroxModel/Discovery/InstallationFinders/EnvironmentGameFinder.cs
Outdated
Show resolved
Hide resolved
|
In which cases does finding the Subnautica path fail? I'm interested in how we can fix the other lookups. |
|
@Measurity My case: server installation via Steam CLI. But I believe there may be other uses in the future (such as Hotfix for the new launcher/breaking changes) |
Jannify
requested changes
Mar 4, 2022
NitroxModel/Discovery/InstallationFinders/EnvironmentGameFinder.cs
Outdated
Show resolved
Hide resolved
…r.cs Co-authored-by: Jannify <23176718+Jannify@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Right now we have no way to specify the install location explicitly. It would be useful to have a way to do this, as other ways can fail and the user can specify the path to the game himself.
Changes
SUBNAUTICA_INSTALLATION_PATH, which doesn't break the current functionality in any way.How to test
SUBNAUTICA_INSTALLATION_PATH(see how here)If you have the game installed and one of the classes above has already found its way, you can test this change by moving that class up.