Built an auto balanced system for prefab spawning #1746
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tornac1234
changed the title
Jannify
requested changes
Mar 26, 2022
|
|
||
| namespace NitroxServer.GameLogic.Entities; | ||
|
|
||
| public abstract class EntityHelper |
There was a problem hiding this comment.
Isn't an interface more fitting here as it requires to implement the method?
| { | ||
| nitroxTechType = worldEntityInfo.techType.ToDto(); | ||
| // At this point, the tech type can still be None, so we need to make sure we return true only if we have a valid tech type | ||
| return nitroxTechType.ToUnity() != TechType.None; |
There was a problem hiding this comment.
Can't we use worldEntityInfo.techType != TechType.None so we don't have a double cast?
Comment on lines
+39
to
+40
| private const float FRAGMENT_LUCK_INDICATOR = 0.2f; | ||
| private const float DEFAULT_LUCK_INDICATOR = 0.1f; |
There was a problem hiding this comment.
As discussed in discord this is not a valid option as the "luck indicator" changes with progression and fragment type afair.
|
Since the issue is fixed, we can close this one for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix for the current issue of player never finding most of the scannable objects spawning around wrecks for example
Fixes #1779