Use ISO639 language codes #1784
Conversation
| @@ -6,6 +6,7 @@ | |||
| <Nullable>disable</Nullable> | |||
| <UseWPF>true</UseWPF> | |||
| <ApplicationIcon>icon.ico</ApplicationIcon> | |||
| <DisableFastUpToDateCheck>True</DisableFastUpToDateCheck> | |||
There was a problem hiding this comment.
What is this purpose of this ?
There was a problem hiding this comment.
The result of this change is that it executes the AfterBuild targets of NitroxLauncher even if just a dependency of it (like Nitrox client) has changed code.
| { | ||
| ___strings[key] = (string)json[key]; | ||
| strings[key] = (string)jsonKey; |
There was a problem hiding this comment.
| strings[key] = (string)jsonKey; | |
| strings[key] = (string)json[key]; |
There was a problem hiding this comment.
If I change it to that I have two dictionary lookups.
| // This language isn't registered in CultureInfo | ||
| if (existingLanguageNames.Contains("Spanish (Latin America)")) | ||
| { | ||
| languageToIsoCode.Add("Spanish (Latin America)", new Tuple<string, string>("es-419", "es")); | ||
| } |
There was a problem hiding this comment.
Even if european spanish and latin america spanish does use different words for the same thing, I don't think it's worth doing special treatment for this one since both countries will understand the sentences (similar for US and UK english)
There was a problem hiding this comment.
While I agree with the thought that it's normally not worth I think we should support any language SN also supports, even if it's just a en vs en-UK thing.
This pr changes our language file names to the ISO639-1 standard. As weblate only outputs these we are kinda required to implement it this way.