Fix player color for different players #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tornac1234
approved these changes
Oct 11, 2022
Coding-Hen
approved these changes
Oct 11, 2022
dartasen
force-pushed
the
fix/playercolor
branch
from
35e3f50
to
0960d85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue where joining players would have the same color as you while their ping has the correct color.
This is achieved by early init of the body prototype before the first color swapping operation. The body prototype shouldn't be colored in the first place since color swapping operations is mapped on the original texture pixels (which are orange)
PS: Might be worth to investigate in a cache for SwapColorOperation since it's the exact same process everytime