-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added analyzer project and a few initial analyzers #1905
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
535cd34
to
fc9374c
Compare
9c4e5a5
to
2f1b24a
Compare
Analyzers MUST target netstandard2.0, do not update unless Microsoft (MSDN) says it's possible.
… API Co-authored-by: Jannify <23176718+jannify@users.noreply.github.com>
…ider CodeFixProvider types should override it by convention.
This analyzer detects if localization key exists in the en.json (English localization). If it does not, then a warning is emitted.
Added simple ITypeSymbol.IsType() that will properly resolve inheritance tree.
…eAnalyzer.cs Changed analyzer to get the type symbol of UnityEngine.Object from the compilation context at startup.
Visual Studio cannot find external libraries compiled with analyzers. See issue: dotnet/roslyn#41785 (comment) For now we regex parse the English localization JSON file.
2 tasks
dartasen
approved these changes
Dec 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnityEngine.Object?.someMember
withUnityEngine.Object.AliveOrNull()?.someMember
UnityEngine.Object
Validate.NotNull
API (makes IDEs understand passed in value can't be null afterwards).Note
StringUsageAnalyzer
because it would cause too many changes.