Creating custom AutoBogus for WorldPersistenceTest and PacketsSerializableTest #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge me
Measurity
requested changes
Apr 16, 2023
Measurity
approved these changes
Apr 22, 2023
dartasen
approved these changes
Apr 22, 2023
Measurity
pushed a commit
to Measurity/Nitrox
that referenced
this pull request
Apr 28, 2023
…zableTest (SubnauticaNitrox#2018) * Fix potential NRE in AssertHelper * Remove old Bogus implementation * Added custom AutoFaker implementation * Use custom faker for WorldPersistenceTest * Updating WorldPersistenceTest with data structure changes * Fixing unnoticed bugs; not anymore with the awesome savedata faker :D * Implement the new faker in the PacketsSerializableTest * Downgrade AutoBogus nuget to Bogus * Address requested changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "official" AutoBogus nuget package provided many problems when using on PersistedWorldData and was also very slow. Therefor I implemented our own version with full customization.
While implementing I fixed a few serialization errors which have slipped the pr reviews.