Added ability to open explorer at Server World save file location on Launcher. #2033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MistaOmega
commented
May 1, 2023
| @@ -405,7 +427,7 @@ private void TBWorldSeed_Input(object sender, KeyboardFocusChangedEventArgs e) | |||
| Config.Seed = TBWorldSeed.Text; | |||
| } | |||
|
|
|||
| private void TBMaxPlayerCap_Input(object sender, System.Windows.Input.KeyboardFocusChangedEventArgs e) | |||
| private void TBMaxPlayerCap_Input(object sender, KeyboardFocusChangedEventArgs e) | |||
There was a problem hiding this comment.
Unsure why, but I think the cleanup profile may have done these changes removing the specific import path. I can add these back if this layout is preferred
There was a problem hiding this comment.
World manager was developed by one of our support team member (non-developer), so this probably due to adding event with XAML editor
dartasen
reviewed
May 3, 2023
There was a problem hiding this comment.
Thank's for working on this 😀
However we're currently rewriting an MVVM launcher with AvaloniaUI that will allow us to start porting the mod to Linux. So I don't know if we should merge this
Feel freeto join our discord, so we can have a talk about it in dev channels !
|
I'm closing this one for now, as discussed on discord |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2020 by adding a button to the server worlds menu to open the save file location of that world.
Used existing settings and icons wherever I could to make this addition as seamless as possible.
I also propose replacing the ellipsis icon for the world settings with the cog icon, allowing me to then use the ellipsis icon for opening the save file location which think would make more sense.
Increased the size of each list element to accommodate the new button whilst keeping the old button sizes the same. 83 -> 125 px in height.