Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple fixes #2089

Merged
merged 4 commits into from
Oct 29, 2023
Merged

Multiple fixes #2089

merged 4 commits into from
Oct 29, 2023

Conversation

tornac1234
Copy link
Collaborator

Each commit has its own stuff

  • Fix Subnautica not running in background in RELEASE ca68b44
  • Improve vitals, they no longer break when in creative mode. Now hidden for remote players in creative mode and shown otherwise. e4d6c35
  • Fix Discord SDK errors when closing discord while in-game, and a retry mechanic to ensure Discord SDK still works after restarting Discord 8a65093
  • Add persistence for GameMode, and a command (exact same as minecraft) so it now requires ADMIN permissions to switch gamemode from yourself or another player 84edf7a
    image

@Jannify Jannify linked an issue Oct 25, 2023 that may be closed by this pull request
Closing Discord while in game spams errors in the logs #2083
Closed
Jannify
Jannify requested changes Oct 25, 2023
View reviewed changes
NitroxClient/MonoBehaviours/NitroxBootstrapper.cs Outdated Show resolved Hide resolved
NitroxPatcher/Patches/Dynamic/Application_runInBackground_Patch.cs Outdated Show resolved Hide resolved
NitroxPatcher/Patches/Dynamic/CrashedShipExploder_OnConsoleCommand_explodeship_Patch.cs Outdated Show resolved Hide resolved
NitroxClient/GameLogic/HUD/PlayerVitalsManager.cs Outdated Show resolved Hide resolved
NitroxClient/GameLogic/HUD/PlayerVitalsManager.cs Outdated Show resolved Hide resolved
NitroxClient/MonoBehaviours/Discord/DiscordClient.cs Outdated Show resolved Hide resolved
NitroxClient/Communication/Packets/Processors/GameModeChangedProcessor.cs Outdated Show resolved Hide resolved
NitroxModel/Packets/GameModeChanged.cs Outdated Show resolved Hide resolved
NitroxPatcher/Patches/Dynamic/GameModeConsoleCommands_OnConsoleCommand_Patch.cs Outdated Show resolved Hide resolved
NitroxServer/ConsoleCommands/GameModeCommand.cs Outdated Show resolved Hide resolved
Jannify
Jannify approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@Jannify Jannify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM CW
Shouldn't be squash merged imo

Measurity
Measurity requested changes Oct 27, 2023
View reviewed changes
NitroxClient/MonoBehaviours/Discord/DiscordClient.cs Outdated Show resolved Hide resolved
NitroxClient/MonoBehaviours/PlayerStatsBroadcaster.cs Outdated Show resolved Hide resolved
NitroxServer/GameLogic/PlayerManager.cs Outdated Show resolved Hide resolved
@dartasen dartasen merged commit f609e89 into SubnauticaNitrox:master Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Measurity Measurity Measurity approved these changes

@dartasen dartasen dartasen approved these changes

@Jannify Jannify Jannify approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Closing Discord while in game spams errors in the logs
4 participants
@tornac1234 @Measurity @dartasen @Jannify