Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintainance: latest C# lang version, code style config fixes, nitrox underscore patch name spell-check ignore, nitrox.analyzer as nuget #2098

Merged
merged 5 commits into from
Dec 26, 2023
Merged

Maintainance: latest C# lang version, code style config fixes, nitrox underscore patch name spell-check ignore, nitrox.analyzer as nuget #2098

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9dc6ab6
Removed Nitrox.Analyzers sources in favor of nuget
Measurity Dec 9, 2023
962bc2a
Set csharp language from 11 to 12
Measurity Dec 9, 2023
70bb571
Updated editorconfig to reflect code style
Measurity Dec 9, 2023
18f9ef4
Added Nitrox patch name convention to remove spell-check warning
Measurity Dec 9, 2023
078063e
Removed AliveOrNull as it's provided by Nitrox.Analyzers now
Measurity Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Removed Nitrox.Analyzers sources in favor of nuget 
Uses * for version to always get latest Nitrox.Analyzers
  • Loading branch information
@Measurity
Measurity committed Dec 13, 2023
commit 9dc6ab6628e11a9c5fe7477a8176fa252eb9b3b9
15 changes: 5 additions & 10 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<PropertyGroup Condition="$([System.Text.RegularExpressions.Regex]::IsMatch($(MSBuildProjectName), '^Nitrox.*$'))">
<NitroxProject>true</NitroxProject>
</PropertyGroup>
<PropertyGroup Condition="'$(NitroxProject)' == 'true' and '$(MSBuildProjectName)' != 'Nitrox.Analyzers'">
<PropertyGroup Condition="'$(NitroxProject)' == 'true'">
<NitroxLibrary>true</NitroxLibrary>
</PropertyGroup>
<PropertyGroup Condition="'$(NitroxLibrary)' == 'true' and '$(MSBuildProjectName)' != 'NitroxModel' and '$(MSBuildProjectName)' != 'NitroxServer' and '$(MSBuildProjectName)' != 'Nitrox.BuildTool'">
Expand All @@ -47,15 +47,6 @@
</When>
</Choose>

<!-- Include our analyzer and code gen library to all Nitrox projects -->
<Choose>
<When Condition="'$(NitroxLibrary)' == 'true'">
<ItemGroup>
<ProjectReference Include="..\Nitrox.Analyzers\Nitrox.Analyzers.csproj" OutputItemType="Analyzer" ReferenceOutputAssembly="false" />
</ItemGroup>
</When>
</Choose>

<!-- Include default project references to all other "Nitrox*" projects -->
<Choose>
<When Condition="'$(UnityModLibrary)' == 'true'">
Expand All @@ -68,6 +59,10 @@
<ProjectReference Include="$(SolutionDir)NitroxModel\NitroxModel.csproj">
<Name>NitroxModel</Name>
</ProjectReference>
<PackageReference Include="Nitrox.Analyzers" Version="*">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
</ItemGroup>
</When>
</Choose>
Expand Down
89 changes: 0 additions & 89 deletions Nitrox.Analyzers/Diagnostics/DependencyInjectionMisuseAnalyzer.cs
View file
Open in desktop

This file was deleted.

61 changes: 0 additions & 61 deletions Nitrox.Analyzers/Diagnostics/EnumeratorUsageAnalyzer.cs
View file
Open in desktop

This file was deleted.

173 changes: 0 additions & 173 deletions Nitrox.Analyzers/Diagnostics/LocalizationAnalyzer.cs
View file
Open in desktop

This file was deleted.

Loading