Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excellently improve player movements in Cyclops #2154

Merged
merged 15 commits into from
Aug 21, 2024
Merged

Excellently improve player movements in Cyclops #2154

merged 15 commits into from
Aug 21, 2024

Conversation

tornac1234
Copy link
Collaborator

@tornac1234 tornac1234 commented Aug 3, 2024 •
edited
Loading

  • Excellently improve local player movements in cyclops
  • Manage remote players movements in the cyclops with this new system
  • Add modules collisions in the virtual cyclops

@tornac1234 tornac1234 changed the title Player movements in cyclops excellent improvements Excellently improve player movements in Cyclops Aug 3, 2024
@tornac1234 tornac1234 added Area: vehicles Related to vehicles (seamoth, cyclops, prawn) Area: player Related to player character actions Area: input Related to game input device handling and key mapping labels Aug 3, 2024
@tornac1234 tornac1234 marked this pull request as ready for review August 6, 2024 18:22
@tornac1234
Copy link
Collaborator Author

Ready for review 😀

@tornac1234
Copy link
Collaborator Author

Two things might need a fix but I'll need some review first:

  • pawn's CharacterController are a bit glitchy when walking on slopes when the player is not fast enough
  • the instant launch mode seems to involve a bug with the logger but I'm not exactly which (they sometimes are duplicated)

@tornac1234
Copy link
Collaborator Author

Note for myself. I might want to have only one virtual cyclops spawned at a time, while the other ones are not activated as long as the player doesn't enter them.

Measurity
Measurity requested changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@Measurity Measurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code only review. Love the 🚀 instant launch 🚀(didn't test cyclops yet)

Here's a patch file for handling the "task error handling" review comments:
https://gist.github.com/Measurity/fac122dcc55b5444d57ef85ca3324036

You can apply it directly from Rider
image
or Get-Clipboard | git apply in Windows Terminal/PowerShell

NitroxLauncher/MainWindow.xaml.cs Outdated Show resolved Hide resolved
NitroxPatcher/Patches/Persistent/uGUI_MainMenu_Start_Patch.cs Outdated Show resolved Hide resolved
NitroxClient/GameLogic/Spawning/Metadata/Processor/CyclopsMetadataProcessor.cs Outdated Show resolved Hide resolved
NitroxPatcher/Patches/Dynamic/FPSCounter_UpdateDisplay_Patch.cs Outdated Show resolved Hide resolved
NitroxClient/MonoBehaviours/MultiplayerVehicleControl.cs Outdated Show resolved Hide resolved
@Measurity Measurity mentioned this pull request Aug 6, 2024
Open
6 tasks
@Measurity Measurity added this to the 1.8 milestone Aug 9, 2024
@tornac1234
Copy link
Collaborator Author

One more commit to come (tomorrow) and I'll have fixed all issues that were listed after a testing session by @dartasen and @NinjaPedroX

tornac1234 and others added 9 commits August 12, 2024 12:45
@tornac1234
Add Instant Launch profile to automatize testing
cd0c85e
@tornac1234
Fix cyclops not restoring motor state on spawn
7e4de49
@tornac1234
Implemented a CyclopsMotor responsible for excellently improving play…
d3c714c 
…er movements in cyclops
@tornac1234
Implement remote players movements in cyclops
1d010c9
@tornac1234
Replicate a cyclop's constructables' colliders in the virtual one
7c4f5a7
@tornac1234
Improvements: only one virtual cyclops for all cyclops, openables no …
7892ebf 
…longer push players, disconnect event is now fired
@tornac1234 @Measurity
Log errors from tasks by .ContinueWith
b426e36 
Co-authored-by: Measurity <measuring.infinity@gmail.com>
@tornac1234
Added CharacterController debug drawer, improve RigidbodyDrawer, fix …
e86d72b 
…player movement in cyclops broadcasting, fix cyclops name and color editor screen not appearing, fix entity reparenting not setting the transform parent accordingly
@tornac1234
Greatly improve player movement in cyclops to fit the normal one, but…
990dd36 
… without the bugs
@tornac1234 tornac1234 mentioned this pull request Aug 13, 2024
Open
1 task
@tornac1234
Add caching during initial sync and fix constructables-collider-copy,…
f42a3e8 
… fix promity detection for both cyclops name/color editor and light panel
@tornac1234
Copy link
Collaborator Author

Needs one more commit to fix unheard steps sounds and cyclops motor being bugged.
Thanks to the results of a 2nd test session by @NinjaPedroX, @dartasen and @Andrew1431, those are the only bugs left

NinjaPedroX added a commit to Measurity/Nitrox that referenced this pull request Aug 15, 2024
@NinjaPedroX @tornac1234
Implemented Tornac's "Instant Launch" profile
eea2f75 
Implemented and adapted Tornac's "Instant Launch" profile from PR SubnauticaNitrox#2154 to the new launcher.

Also fixed a thread error for when one is thrown while multiplayer is being launched, as well as changing errors thrown during server startup from being a notification to being an error dialog.

Co-Authored-By: rootcan <24827220+tornac1234@users.noreply.github.com>
dartasen
dartasen approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@dartasen dartasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will create an issue about the movement rework as a follow up to comments (if the issue doesn't already exist)

@Measurity Measurity removed the request for review from Coding-Hen August 21, 2024 21:06
@tornac1234 tornac1234 merged commit 07cdb19 into SubnauticaNitrox:master Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Measurity Measurity Measurity approved these changes

@dartasen dartasen dartasen approved these changes

Assignees
No one assigned
Labels
Area: input Related to game input device handling and key mapping Area: player Related to player character actions Area: vehicles Related to vehicles (seamoth, cyclops, prawn)
Projects
None yet
Milestone
1.8
Development

Successfully merging this pull request may close these issues.
3 participants
@tornac1234 @Measurity @dartasen