Networking Enhancements #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Fix server crash on hard disconnect -Detect client disconnect -Remove player object from server+other clients when disconnected -Disconnect packet added -Disconnect command added
-Made Disconnect packet serializable -Wrapped Socket read/writes in try/catch blocks -Made playersById in Listener a Dictionary with outside locking --Internal synchronization will not work against outside iteration+modification --Don't use two locks for no reason; ConcurrentMap is no longer needed -Round two for trying to remove inactive player objects
-Only allowed to connect to one server at a time -Display connected/disconnected messages in-game -Fixed Disconnect packet processing (round 3) -Fixed multiple Mono Behavior loading -Only process packets if connected to server --Possible issue: Packets will be sent, user will disconnect, the next reconnect will process these old packets first -More error handling - server should not crash from connects/disconnects
-Fixed ClientTester crash -Fixed issue where a disconnection without authenticating would cause a server crash
Sunrunner37
approved these changes
Jul 9, 2017
| @@ -14,7 +14,10 @@ namespace NitroxServer | |||
| { | |||
| public class Listener | |||
| { | |||
| private ConcurrentMap<String, Player> playersById = new ConcurrentMap<String, Player>(); | |||
| // A ConcurrentMap will not protect against concurrency issues when | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
NitroxServer/Listener.cs
Outdated
| } | ||
| } | ||
| } | ||
|
|
||
| private void SendCompleted(IAsyncResult ar) | ||
| { | ||
| Thread.Sleep(40); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| [Serializable] | ||
| public class Disconnect : Packet | ||
| { | ||
|
|
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| if (connection.Open) | ||
| { | ||
| connection.BeginReceive(new AsyncCallback(DataReceived)); | ||
| } else |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
|
||
| private void outputMessage(String msg) | ||
| { | ||
| if (testClient) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
nesrak1
pushed a commit
to nesrak1/Nitrox
that referenced
this pull request
Aug 29, 2017
Networking Enhancements
dartasen
pushed a commit
to dartasen/Nitrox
that referenced
this pull request
Apr 15, 2023
.ToHashSet() doesn't exist in .NetStandard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix server crashes due to network read/write failures, Socket failures. Remove player model when disconnected.