-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/refactor server configuration #415
Feature/refactor server configuration #415
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a much better config handling. Thanks 👍 I only got some small things for you to look at.
{ | ||
this.packetHandler = packetHandler; | ||
this.playerManager = playerManager; | ||
this.entitySimulation = entitySimulation; | ||
PortNumber = ConfigReader.serverPort; | ||
MaxConn = ConfigReader.maxConn; | ||
PortNumber = ConfigReader.ServerPort; |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
remove comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
{ | ||
this.packetHandler = packetHandler; | ||
this.playerManager = playerManager; | ||
this.entitySimulation = entitySimulation; | ||
PortNumber = ConfigReader.serverPort; | ||
MaxConn = ConfigReader.maxConn; | ||
PortNumber = ConfigReader.ServerPort; |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This is the standard way in .Net to use configuration and it will be a valuable asset to your project.
Also, this way you always get a default configuration on the build