Replaced lidgren with litenetlib for connection lost issues #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we'll want to refactor this so we can support multiple parallel implementations (at least for the time being). Ideally, users can select the implementations via the configuration file in the server. Clients can either try both when connecting or negotiate with a primary and switch to the secondary if required. Thoughts? |
|
That would be great. Me and my friend will consider an implementation of that feature and keep you updated. |
|
Parallel implementation in #664 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced lidgren as the networking library with litenetlib as an attempt to resolve the connection lost issue some people encounter, that were not based on port forwarding issues.
After some hours of testing, no random disconnects occurred in our testing environment, when before they occurred approximately every 0.5-5 minutes.
For absolute clarification, if this is the reason for the random disconnects, further testing with the community is required.
On the technical side:
The code is loosely based on the networking branch.
I had to create a WrapperPacket for the litenetlib serializer because I did not want to refactor the whole packet handling. For better performance (maybe?) it would be possible to refactor the packet handling.