Added beacon name sync #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Measurity
force-pushed
the
beacon-name-sync
branch
2 times, most recently
from
90f06ba
to
3301427
Compare
Measurity
force-pushed
the
beacon-name-sync
branch
from
3301427
to
e3a525b
Compare
Measurity
force-pushed
the
beacon-name-sync
branch
from
d94f4bc
to
baa2e89
Compare
dartasen
approved these changes
Mar 31, 2020
Sunrunner37
reviewed
Apr 4, 2020
|
|
||
| do | ||
| // Some packets should not fire during game session join but only afterwards so that initialized/spawned game objects don't trigger packet sending again. | ||
| using (packetSender.Suppress<PingRenamed>()) |
There was a problem hiding this comment.
Should we add this closer to the code that invokes this?
Comment on lines
+27
to
+42
| if (!obj.HasValue) | ||
| { | ||
| // Not the object we're looking for. | ||
| return; | ||
| } | ||
| Beacon beacon = obj.Value.GetComponent<Beacon>(); | ||
| if (!beacon) | ||
| { | ||
| // This can be ok if origin of ping instance component was not from a beacon (but from signal or other). | ||
| return; | ||
| } | ||
| if (beacon.GetComponent<Player>()) | ||
| { | ||
| // Skip over beacon component on player GameObjects | ||
| return; | ||
| } |
There was a problem hiding this comment.
log the ones that are error?
There was a problem hiding this comment.
None of these have to be errors. And this information doesn't seem useful most of the time. I wish we had some .Trace() or just disable logs from this class by default.
| public string Name { get; } | ||
|
|
||
| [ProtoMember(3)] | ||
| public byte[] BeaconGameObjectSerialized { get; } |
There was a problem hiding this comment.
No, all beacons have pings.
Measurity
force-pushed
the
beacon-name-sync
branch
from
baa2e89
to
109748e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppressed the ping/beacon rename packet on initial sync so that connecting players don't fire beacon rename packets.
Initially I used
PingManager.onRenamedevent but doing it this way would deviate from the standard patching mechanism so I went with a patch instead.