Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we default the collection process to exclude Sumologic Logs #211

Closed
abhi-sumo-zz opened this issue Sep 23, 2019 · 3 comments · Fixed by #682
Closed

Can we default the collection process to exclude Sumologic Logs #211

abhi-sumo-zz opened this issue Sep 23, 2019 · 3 comments · Fixed by #682
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@abhi-sumo-zz
Copy link
Contributor

abhi-sumo-zz commented Sep 23, 2019

The suggestion that we should default to excluding the sumologic namespace as those are primarily sumo specific logs.

@frankreno
Copy link
Contributor

I think a good implementation of this would be to modify the Helm chart to have a flag like sumologic.collectionMonitoring, defaulted to true. IF you set it to false, it would set EXCLUDE_NAMESPACE=sumologic and not add the fluentD/fluent-bit and Prometheus remotestorage metrics.

@rvmiller89
Copy link
Contributor

We rely on those logs to debug issues so it may be best to default to collecting them, but allow the customer to disable them (with the understanding we won't be able to triage issues they may encounter)?

@frankreno
Copy link
Contributor

Agreed on default being true, but conditional enablement for the win here

@vsinghal13 vsinghal13 added the enhancement New feature or request label Mar 6, 2020
@frankreno frankreno added this to the v1.1 milestone May 12, 2020
@vsinghal13 vsinghal13 self-assigned this May 26, 2020
psaia pushed a commit to psaia/sumologic-kubernetes-collection that referenced this issue May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants