Add priorityClassName to events statefulset #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumo-drosiek
requested review from
a team,
frankreno,
samjsong,
vsinghal13,
perk-sumo,
andrzej-stencel and
pmalek-sumo
and removed request for
a team
sumo-drosiek
force-pushed
the
drosiek-events-priority-class-name
branch
from
be47f2b
to
21c7713
Compare
sumo-drosiek
force-pushed
the
drosiek-events-priority-class-name
branch
from
21c7713
to
15a851b
Compare
sumo-drosiek
force-pushed
the
drosiek-events-priority-class-name
branch
from
d6a80dc
to
9ffe539
Compare
pmalek-sumo
reviewed
Oct 14, 2020
| @@ -24,8 +24,8 @@ Parameter | Description | Default | |||
| `sumologic.endpoint` | Sumo API endpoint; Leave blank for automatic endpoint discovery and redirection. | `Nil` | |||
| `sumologic.collectorName` | The name of the Sumo Logic collector that will be created in the SetUp job. Defaults to `clusterName` if not specified. | `Nil` | |||
| `sumologic.clusterName` | An identifier for the Kubernetes cluster. | `kubernetes` | |||
| `sumologic.httpProxy` | HTTP proxy URL | `` | |||
| `sumologic.httpsProxy` | HTTPS proxy URL | `` | |||
| `sumologic.httpProxy` | HTTP proxy URL | `Nil` | |||
There was a problem hiding this comment.
Why Nil? Isn't an empty string a better value for this? i.e. ""?
There was a problem hiding this comment.
We are using Nil as empty string across all file
vsinghal13
approved these changes
Oct 14, 2020
sumo-drosiek
added a commit
that referenced
this pull request
Oct 15, 2020
* Add priorityClassName to events statefulset * Update options in README.md
sumo-drosiek
added a commit
that referenced
this pull request
Oct 15, 2020
* Add priorityClassName to events statefulset * Update options in README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add priorityClassName to events statefulset
Testing performed