-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add development disclaimer #101
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvmiller89
reviewed
Jul 30, 2019
rvmiller89
approved these changes
Jul 30, 2019
this will build an alpha docker image 😆 |
lei-sumo
approved these changes
Jul 30, 2019
frankreno
approved these changes
Jul 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
psaia
pushed a commit
to psaia/sumologic-kubernetes-collection
that referenced
this pull request
May 25, 2021
psaia
pushed a commit
to psaia/sumologic-kubernetes-collection
that referenced
this pull request
May 25, 2021
* Instructions for using the adutil * Update security team's filter (SumoLogic#99) * PUBP-8182: provision elections collector (SumoLogic#98) * PUBP-8182: provision elections collector * PUBP-8182: provision elections collector * PUBP-8182: renaming module to match repo name * PUBP-8182: renaming output Co-authored-by: Malcolm Jones <17786500+mlclmj@users.noreply.github.com> * Add logging for AD parameters (SumoLogic#95) * Log the vars subitted * fix wording, enumerate commands directly * drone sign Co-authored-by: Marcin Suterski <msuterski@users.noreply.github.com> * added collector for nytm/dv-drone in TF (SumoLogic#100) * Adding collector for spg-inyt-subscription-api (SumoLogic#101) * remove 'manageIndexes' from samizdat role (SumoLogic#102) * Add ADR regarding AD groups and nesting (SumoLogic#12) * adr 7 * Update and rename 0007-controlling-role-access-through-ad.md to 0008-controlling-role-access-through-ad.md * Feature/add collector int fallback role (SumoLogic#104) * adding new collector to the role * adding new collector to the role * Adutil instructions moved to dv-docs * update link Co-authored-by: Marcin Suterski <msuterski@users.noreply.github.com> Co-authored-by: Shreelekha Tanna <shree.tanna@nytimes.com> Co-authored-by: Malcolm Jones <17786500+mlclmj@users.noreply.github.com> Co-authored-by: Prune Sebastien THOMAS <prune@lecentre.net> Co-authored-by: satyabodharao <47533173+satyabodharao@users.noreply.github.com> Co-authored-by: Shawn Bower <shawn.bower@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realized we don't explicitly mention anywhere that this solution is still in development - figured we should add a disclaimer to the README. Wasn't sure about the wording, any feedback would be appreciated.