OpenTelemetry Agent support #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pmm-sumo What is the purpose of the opentelemetry agent? |
Essentially, this makes scaling much more efficient. Agent gets the local connections, buffers data and sends those to collector. Eventually, tagging should move on there as well: https://opentelemetry.io/docs/collector/about/#agent |
perk-sumo
approved these changes
Oct 23, 2020
sumo-drosiek
previously requested changes
Nov 10, 2020
When `otelagent.enabled=true`, deploys a DeamonSet with OpenTelemetry Collector running in Agent mode, configured to send data to the OpenTelemetry Collector instance.
Co-authored-by: Dominik Rosiek <58699848+sumo-drosiek@users.noreply.github.com>
|
Sorry for the delay. The requests came when I was on a sick-leave and missed them. In either case - prepared the fixes. Going to test them bit later. But so far - does it look OK now @sumo-drosiek ? |
|
@pmm-sumo yup, this is fine. Just one another ask, please update README.md with the new configuration 😅 |
sumo-drosiek
requested review from
andrzej-stencel,
frankreno,
kasia-kujawa and
pmalek-sumo
as code owners
pmalek-sumo
reviewed
Nov 24, 2020
pmalek-sumo
reviewed
Nov 24, 2020
pmalek-sumo
reviewed
Nov 24, 2020
Co-authored-by: Patryk Małek <69143962+pmalek-sumo@users.noreply.github.com>
Co-authored-by: Patryk Małek <69143962+pmalek-sumo@users.noreply.github.com>
pmalek-sumo
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
otelagent.enabled=true, deploys a DeamonSet with OpenTelemetry Collector running in Agent mode, configured to send data to the OpenTelemetry Collector instance.Testing performed