Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate off of the legacy pre-1.14 recording rules #1030

Merged
merged 3 commits into from
Nov 30, 2020
Merged

Migrate off of the legacy pre-1.14 recording rules #1030

merged 3 commits into from
Nov 30, 2020

Conversation

vsinghal13
Copy link
Contributor

Description
  • Removed the flag kubeTargetVersionOverride: 1.13.0-0
  • following node rule metrics have been removed in from 1.14, so we have to add them to our values file.
Metrics
:node_cpu_saturation_load1:
:node_cpu_utilisation:avg1m
:node_disk_saturation:avg_irate
:node_disk_utilisation:avg_irate
:node_memory_swap_io_bytes:sum_rate
:node_memory_utilisation:
:node_net_saturation:sum_irate
:node_net_utilisation:sum_irate
node:cluster_cpu_utilisation:ratio
node:cluster_memory_utilisation:ratio
node:node_cpu_saturation_load1:
node:node_cpu_utilisation:avg1m
node:node_disk_saturation:avg_irate
node:node_disk_utilisation:avg_irate
node:node_filesystem_avail:
node:node_filesystem_usage:
node:node_inodes_free:
node:node_inodes_total:
node:node_memory_bytes_total:sum
node:node_memory_swap_io_bytes:sum_rate
node:node_memory_utilisation:
node:node_memory_utilisation:ratio
node:node_memory_utilisation_2:
node:node_net_saturation:sum_irate
node:node_net_utilisation:sum_irate
  • following apiserver and kube-scheduler have been replaced/renamed in 1.14
Pre-1.14 apiserver and kube-scheduler recording rules Post-1.14 apiserver and kube-scheduler recording rules
cluster_quantile:apiserver_request_latencies:histogram_quantile cluster_quantile:apiserver_request_duration_seconds:histogram_quantile
cluster_quantile:scheduler_binding_latency:histogram_quantile cluster_quantile:scheduler_binding_duration_seconds:histogram_quantile
cluster_quantile:scheduler_e2e_scheduling_latency:histogram_quantile cluster_quantile:scheduler_e2e_scheduling_duration_seconds:histogram_quantile
cluster_quantile:scheduler_scheduling_algorithm_latency:histogram_quantile cluster_quantile:scheduler_scheduling_algorithm_duration_seconds:histogram_quantile
Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@perk-sumo perk-sumo added this to the v2.0 milestone Oct 23, 2020
@perk-sumo perk-sumo closed this Oct 28, 2020
@perk-sumo perk-sumo reopened this Oct 28, 2020
perk-sumo
perk-sumo reviewed Oct 28, 2020
View reviewed changes
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we add pre-1.14-node-rules in here and not calculate this on the Sumo backend if needed?

sumo-drosiek
sumo-drosiek suggested changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove auto-generated files due to #1052

frankreno
frankreno approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@perk-sumo perk-sumo closed this Nov 24, 2020
@perk-sumo perk-sumo deleted the branch main November 24, 2020 12:53
@sumo-drosiek sumo-drosiek mentioned this pull request Nov 24, 2020
Closed
@sumo-drosiek sumo-drosiek reopened this Nov 24, 2020
@sumo-drosiek sumo-drosiek changed the base branch from master to main November 24, 2020 13:05
@sumo-drosiek sumo-drosiek requested a review from a team November 24, 2020 13:05
@pmalek-sumo pmalek-sumo self-assigned this Nov 30, 2020
@pmalek-sumo pmalek-sumo force-pushed the vsinghal-pre-1.14-recording-rules branch from 47f9af0 to 1429c73 Compare November 30, 2020 15:09
sumo-drosiek
sumo-drosiek approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK

@pmalek-sumo pmalek-sumo merged commit 63c6cf3 into main Nov 30, 2020
@pmalek-sumo pmalek-sumo deleted the vsinghal-pre-1.14-recording-rules branch November 30, 2020 15:44
@perk-sumo
Copy link
Contributor

Migration script PR: #1216

@pmalek-sumo pmalek-sumo mentioned this pull request Dec 21, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perk-sumo perk-sumo perk-sumo left review comments

@frankreno frankreno frankreno approved these changes

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel

@kasia-kujawa kasia-kujawa Awaiting requested review from kasia-kujawa

@pmalek-sumo pmalek-sumo Awaiting requested review from pmalek-sumo

Assignees

@pmalek-sumo pmalek-sumo

Labels
breaking-change
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
6 participants
@vsinghal13 @perk-sumo @frankreno @sumo-drosiek @pmalek-sumo @pmalek