-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use helm from kubernetes-tools #1054
Conversation
becfd8f
to
706fa09
Compare
55c787c
to
8e00963
Compare
c5e97f4
to
7acf062
Compare
f52709e
to
7acf062
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall 👍 but one thing seems fishy.
ci/build.sh
Outdated
docker run --rm \ | ||
-v "$(pwd):/chart" \ | ||
-w /chart \ | ||
sumologic/kubernetes-tools:master \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be master
but rather latest
or just fixed version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but let's make sure we are on fixed tools
version when it's ready.
7acf062
to
1d82817
Compare
No description provided.