Add monitoring for FluentD plugins #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 30, 2019 17:00
lei-sumo
previously approved these changes
Aug 1, 2019
| @@ -4,6 +4,8 @@ | |||
| require_relative '../../types_pb' | |||
| require_relative '../../remote_pb' | |||
|
|
|||
| WriteRequest = Prometheus::WriteRequest | |||
There was a problem hiding this comment.
Do you really need this change?
There was a problem hiding this comment.
Yes, otherwise our module Prometheus conflicts with the fluentd-prometheus plugin's module Prometheus and our parsing breaks.
frankreno
reviewed
Aug 1, 2019
| ports: | ||
| - name: metrics | ||
| port: 24231 | ||
| targetPort: 24231 |
There was a problem hiding this comment.
Not needed for now, but we should look at using named ports for the targetPort so we dont have to update the Pod and Service each time.
samjsong
approved these changes
Aug 1, 2019
psaia
pushed a commit
to psaia/sumologic-kubernetes-collection
that referenced
this pull request
May 25, 2021
* Support group managers * add test group * apply to test * include drone file in pipelines * update to marcin * remove second file * remove test file * update compiled providers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes Prometheus metrics (currently just output plugin metrics) for fluentd and fluentd-events deployments.
